This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Improvements to make 4.x compatible with different projects #5130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
requested review from
avkos,
jdevcs,
luu-alex,
nikoulai and
spacesailor24
13 tasks
avkos
approved these changes
Jun 14, 2022
jdevcs
suggested changes
Jun 14, 2022
jdevcs
suggested changes
Jun 14, 2022
| import { IbanOptions } from './types'; | ||
| import { Web3Iban } from './web3_iban'; | ||
|
|
||
| export class Iban { |
There was a problem hiding this comment.
Why we need this refactor to new file?
There was a problem hiding this comment.
To have a consistent pattern around the code base. To have classes in files as their names. It's easy to search in the code.
luu-alex
approved these changes
Jun 14, 2022
nikoulai
approved these changes
Jun 16, 2022
16 tasks
jdevcs
approved these changes
Jun 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5125
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.